So when my sifu does them on me it hurts a lot and they are very effective but when I do them on other people I fail at them.
In your opinion are pressure points a viable thing to train in? I mean yeah I know they work because they were done on me but, the reason I ask this is because many of them in our style are done during grapples and takedowns, where I could just instead punch or elbow them and do that much easier
Hmmm.... I have answered this question in the past this way.
Student: "Man, this technique simply does not work!"
Instructor: "Which technique?"
S: "This one." *attempted demonstration*
I: "Oh, yes. That is very good. But, you missed the {WHATEVER}, and you should correct by doing {WHATEVER}. See, like this..." *Demonstration*
S: "Yowchie!! How did you do that."
I: "The tecnique works fine. Your technique doesn't. There is a difference."
...and I could also point out that punching or elbowing the opponent, while easier and probably effective, is an overt act of hostility and can get someone in trouble if seen or caught on video and thought to be "too much violence." It is something to think about. But... pressure points don't even look like they should work, but they do and nobody saw you do much of anything. A good option to have in your tool bag.